[sival,tests] Allow excessive csrng irqs in plic_all_irqs_test #20758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matutem
requested review from
nbdd0121,
msfschaffner and
HU90m
and removed request for
msfschaffner
matutem
force-pushed
the
fpga_plic_all_irqs
branch
from
7fdee1b to
ebaa22c
Compare
matutem
force-pushed
the
fpga_plic_all_irqs
branch
2 times, most recently
from
fc72610 to
f6a0906
Compare
matutem
changed the title
|
Should we fix this in the ROM_EXT instead? |
| peripheral_expected, peripheral); | ||
| if (allow_csrng_irq && kBootStage == kBootStageOwner && | ||
| peripheral != peripheral_expected && | ||
| peripheral == kTopEarlgreyPlicPeripheralCsrng) { |
There was a problem hiding this comment.
Should we refer to #20747 at this point?
There was a problem hiding this comment.
I added references at other points. A reference here will not hurt. Done.
matutem
force-pushed
the
fpga_plic_all_irqs
branch
from
f6a0906 to
61db38a
Compare
matutem
changed the title
matutem
force-pushed
the
fpga_plic_all_irqs
branch
from
61db38a to
ddd5680
Compare
Carefully allow these excessive irqs for the correct portion of the tests, addressing lowRISC#20747 so this test passes. Add a TODO against the issue above so the code is adjusted depending on how the issue is addressed. Enable these tests in fpga_cw310_sival_rom_ext. Signed-off-by: Guillermo Maturana <[email protected]>
matutem
force-pushed
the
fpga_plic_all_irqs
branch
from
ddd5680 to
93cdae2
Compare
moidx
approved these changes
Jan 13, 2024
|
We should consider writing an entropy complex test to tweak the EDN settings and monitors this interrupt. I am not sure which EDN endpoint is causing the interrupt to trigger so often. Maybe enabling the EDN |
|
The failure is unrelated, so this is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carefully allow these excessive irqs for the correct portion of
the tests, addressing #20747 so this test passes.
Add a TODO against the issue above so the code is adjusted
depending on how the issue is addressed.
Enable these tests in fpga_cw310_sival_rom_ext.